-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Open Orders #293
Comments
@goodboy I think ill take a crack at this guy next, since I use kraken to hold open orders. It would be nice to be able to save dark orders too, something I can tackle afterwards. |
goodboy
added a commit
that referenced
this issue
Jul 3, 2022
Moves to using the new `piker.pp` apis to both store real-time trade events in a ledger file as well emit position update msgs (which were not in this backend at all prior) when new orders clear (aka fill). In terms of outstanding issues, - solves the pp update part of the bugs reported in #310 - starts a msg case block in prep for #293 Details of rework: - move the `subscribe()` ws fixture to module level and `partial()` in the client token instead of passing it to the instance; in prep for removal of the `.token` attr from the `NoBsWs` wrapper. - drop `make_auth_sub()` since it was too thin and we can just do it all succinctly in `subscribe()` - filter trade update msgs to those not yet stored int the toml ledger - much better kraken api msg unpacking using new `match:` synax B) Resolves #311
man, I am a stale ol' bish, well get on this asap |
@iamzoltan we're basically primed for it after #349 lands if interested 😉 |
Prettty sure this was completely solved in #374. |
Follow up in #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be nice if we could add a message schema to deal with open orders stored with your broker, so that we could grab them and display them on piker.
In addition, I would like to add the possibility to save and reload dark orders and potentially paper engine orders as well.
The text was updated successfully, but these errors were encountered: