Ordermode pps #205
Merged
Ordermode pps #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
added
data-layer
goodboy
force-pushed
the
ordermode_pps
branch
7 times, most recently
from
99a9500 to
bae23a6
Compare
Merged
goodboy
force-pushed
the
ordermode_pps
branch
from
9bf40fe to
e4d02f8
Compare
goodboy
commented
Sep 5, 2021
| @@ -1295,10 +1297,14 @@ def pack_position(pos: Position) -> dict[str, Any]: | |||
| else: | |||
| symbol = con.symbol | |||
|
|
|||
| symkey = '.'.join([ | |||
| symbol.lower(), | |||
| (con.primaryExchange or con.exchange).lower(), | |||
There was a problem hiding this comment.
This fixes a bug where on pp loading from the broker, a sub-string of the actual intended instrument symbol would match showing a pp indicator for the wrong chart. explicitly truncating and appending the exchange solves this.
goodboy
commented
Sep 5, 2021
|
|
||
| else: | ||
| await stream.send({sym: quote}) | ||
| with trio.move_on_after(0.2) as cs: |
There was a problem hiding this comment.
This is effectively a backpressure detector and should basically never get entered unless there's an issue on the consumer side (which hopefully all these are resolved now).
Not sure if we should put this onto master though with the .breakpoint() but I haven't seen it happen yet in practice.
goodboy
commented
Sep 5, 2021
|
|
||
| class LinkedSplits(QtWidgets.QWidget): | ||
| class ChartnPane(QFrame): |
There was a problem hiding this comment.
Composite to make the order pane stuff work alongside the linked split charts.
Acts as a fix for lodpi and better sizing logic for the pp status bar. Drop all the redundant passing of the form to its child layouts during instantiating (since they're all added as layouts to the tree). Comment out the feed status label for now since it's not hooked up to the backend and we'll get it going in a new PR. Down the road we probably want to do all the pp pane component-widget sizing *after* the `pyqtgraph` chart is up; it's going to take some reworking of the charting api tho.
We weren't updating the LHS size labels on creation and we now use the lot size digits to do so. Change `PositionTracker.update()` to `.update_from_pp_msg()`.
goodboy
force-pushed
the
ordermode_pps
branch
from
01184db to
3713831
Compare
goodboy
force-pushed
the
ordermode_pps
branch
5 times, most recently
from
30d0317 to
21019e6
Compare
goodboy
force-pushed
the
ordermode_pps
branch
from
21019e6 to
202b857
Compare
This was referenced Sep 6, 2021
|
Follow up issue list inspired or drafted in this patch set:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working draft of highly game-like position and order tracking for order mode.
Target feature list:
paperboiengine is loaded with it's feeds; we need a fix for this.positions.toml? Probably want to coordinate with Phil MacKraken #214.