Compact L1 labels #452
Merged
Compact L1 labels #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
force-pushed
the
epoch_indexing_and_dataviz_layer
branch
from
ead2e1e to
956cacb
Compare
goodboy
force-pushed
the
l1_compaction
branch
from
4281005 to
97e0aae
Compare
guilledk
force-pushed
the
epoch_indexing_and_dataviz_layer
branch
from
956cacb to
b112d0e
Compare
goodboy
force-pushed
the
epoch_indexing_and_dataviz_layer
branch
from
b112d0e to
340045a
Compare
goodboy
force-pushed
the
l1_compaction
branch
from
97e0aae to
f1f812e
Compare
Instead of having the l1 lines be inside the view space, move them to be inside their respective axis (with only a 16 unit portion inside the view) such that the clear price label can overlay with them nicely without obscuring; this is much better suited to multiple adjacent y-axes and in general is simpler and less noisy. Further `L1Labels` + `LevelLabel` style tweaks: - adjust `.rect` positioning to be "right" (i.e. inside the parent y-axis) with a slight 16 unit shift toward the viewbox (using the new `._x_br_offset`) to allow seeing each level label's line even when the clearing price label is positioned at that same level. - add a newline's worth of vertical space to each of the bid/ask labels so that L1 labels' text content isn't ever obscured by the clear price label. - set a low (10) z-value to ensure l1 labels are always placed underneath the clear price label. - always fill the label rect with the chosen background color. - make labels fully opaque so as to always make them hide the parent axes' `.tickStrings()` contents. - make default color the "default" from the global scheme. - drop the "price" part from the l1 label text contents, just show the book-queue's amount (in dst asset's units, aka the potential clearing vlm).
Goes back to always adjusting the y-axis range to include the L1 spread and clearing label in view whenever the last datum is also in view, previously this was broken after reworking the display loop for multi-feeds. Drops a bunch of old commented tick looping cruft from before we started using tick-type framing. Also adds more stringent guards for ignoring but error logging quote values that are more then 25% out of range; it seems particularly our `ib` feed has some issues with strange `price` values that are way off here and there?
goodboy
force-pushed
the
l1_compaction
branch
from
f1f812e to
cee6321
Compare
guilledk
approved these changes
Feb 13, 2023
77 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New styling for our L1 spread labels drawn on the fast chart, again, in support of the oncoming #420.
