Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new msgspec default factories #457

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Use new msgspec default factories #457

merged 1 commit into from
Feb 12, 2023

Conversation

guilledk
Copy link
Contributor

Added on msgspec v0.13.0, for more information about this change see: jcrist/msgspec#274

@guilledk guilledk added the bug guille broke it prolly label Feb 11, 2023
@guilledk guilledk requested a review from goodboy February 11, 2023 19:12
@guilledk guilledk self-assigned this Feb 11, 2023
goodboy
goodboy approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@goodboy goodboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, interesting they went with the @dataclass style. I gotta read that changelog in more detail.

@guilledk guilledk merged commit f0b17cb into master Feb 12, 2023
@guilledk guilledk deleted the msgspec-default-factories branch February 12, 2023 16:17
@goodboy goodboy mentioned this pull request Feb 14, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodboy goodboy goodboy approved these changes

Assignees

@guilledk guilledk

Labels
bug guille broke it prolly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilledk @goodboy