Explicitly write pps.toml on exit for ib and kraken
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
added
clearing
goodboy
force-pushed
the
explicit_write_pps_on_exit
branch
from
1d0c307 to
569df45
Compare
goodboy
commented
Mar 1, 2023
|
|
||
|
|
||
| @cm | ||
| def open_ledger( |
There was a problem hiding this comment.
oh right, and i have no idea what the heck this was from lul
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the default setting change to
.pp.open_pps()to not write the TOML file on close, this adjusts theibandkrakenbackends to set the write flag explicitly and indeed update the pps file on teardown.Further, this includes the removal of the trades history record-limit since there seems to be no particular reason to halt on the last 10 transactions, though eventually we should probably expose this through the
brokers.toml?