Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error compiling on Raspbian Raspbian GNU/Linux 8 (jessie) #5

Closed
dandfra opened this issue May 17, 2019 · 5 comments
Closed

Error compiling on Raspbian Raspbian GNU/Linux 8 (jessie) #5

dandfra opened this issue May 17, 2019 · 5 comments
Assignees
@mdevaev
Labels
resolution:fixed Fixed type:bug Something isn't working

Comments

@dandfra
Copy link

dandfra commented May 17, 2019

in the linking phase it says that the symbol libevent_global_shutdown is missing (in the compilethere is a warning).
I workarounded by commenting out (it's used to cleanup before destroy, but is not really neded)
@mdevaev mdevaev self-assigned this May 17, 2019
@mdevaev mdevaev added the type:bug Something isn't working label May 17, 2019
@mdevaev
Copy link
Member

mdevaev commented May 17, 2019

Which version of libevent you used?

@dandfra
Copy link
Author

dandfra commented May 17, 2019 via email

mdevaev added a commit that referenced this issue May 17, 2019
@mdevaev
Issue #5: Added libevent version check
ddb3db8
@mdevaev
Copy link
Member

mdevaev commented May 17, 2019

Gotcha. libevent_global_shutdown() was implemented in version 2.1.1. I've added additional check for this. Please try it from master. Also I recommend to use a newer version of libevent because it's being actively developed and contains many bugfixes.

@dandfra
Copy link
Author

dandfra commented May 17, 2019

Ok, I confirm that now it compiles, thanks a lot.
FYI libevent 2.0 is the version in both jesse and stretch (https://packages.debian.org/search?keywords=libevent).

@dandfra dandfra closed this as completed May 17, 2019
@mdevaev
Copy link
Member

mdevaev commented May 17, 2019

Cool. Thanks for the issue! I'll make a new ustreamer release.

schneemaier pushed a commit to schneemaier/ustreamer that referenced this issue Nov 5, 2022
@mtlynch @602p
Assign stream index on outgoing RTP packets (pikvm#182)
4f0abf7 
* Assign stream index on outgoing RTP packets (pikvm#5)

* Correctly assign mindex on outgoing rtp packets

Previously mindex was not set and defaulted to zero. This lead to most packets
getting dropped because of sequence number reuse when streaming both audio and
video. This reorders the SDP entries for video and audio so that video is first
in both a video-only and a audio+video configuration. This means that the mindex
for video packets should always be zero, and for audio (if present) should
always be one. This assumes there will never be an audio-only configuration.

* Adjust comments

Co-authored-by: Michael Lynch <[email protected]>

* Add preprocessor conditional to guard packet.mindex setting

The mindex field wasn't added to the janus_plugin_rtp_packet until Janus 1.0, so this change adds a precompiler check to ensure JANUS_PLUGIN_API_VERSION is >= 100 before assigning a value to the mindex field.

* Preserve audio-then-video ordering for Janus 0.x

Co-authored-by: Louis Goessling <[email protected]>
schneemaier pushed a commit to schneemaier/ustreamer that referenced this issue Nov 5, 2022
@mtlynch @602p
Assign stream index on outgoing RTP packets (pikvm#182)
ca30656 
* Assign stream index on outgoing RTP packets (pikvm#5)

* Correctly assign mindex on outgoing rtp packets

Previously mindex was not set and defaulted to zero. This lead to most packets
getting dropped because of sequence number reuse when streaming both audio and
video. This reorders the SDP entries for video and audio so that video is first
in both a video-only and a audio+video configuration. This means that the mindex
for video packets should always be zero, and for audio (if present) should
always be one. This assumes there will never be an audio-only configuration.

* Adjust comments

Co-authored-by: Michael Lynch <[email protected]>

* Add preprocessor conditional to guard packet.mindex setting

The mindex field wasn't added to the janus_plugin_rtp_packet until Janus 1.0, so this change adds a precompiler check to ensure JANUS_PLUGIN_API_VERSION is >= 100 before assigning a value to the mindex field.

* Preserve audio-then-video ordering for Janus 0.x

Co-authored-by: Louis Goessling <[email protected]>
@samuk samuk mentioned this issue Feb 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdevaev mdevaev

Labels
resolution:fixed Fixed type:bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdevaev @dandfra