basic plugin handling #1312
Merged
basic plugin handling #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geier
force-pushed
the
develop/plugins
branch
3 times, most recently
from
a74a9b8 to
35a706a
Compare
Closed
geier
commented
Oct 29, 2023
khal/cli.py
Outdated
| """List all events between a start (default: today) and (optional) | ||
| end datetime.""" | ||
| enabled_eventformatters = plugins.FORMATTERS | ||
| logger.warn("TODO: register user given format string as a plugin") |
There was a problem hiding this comment.
@tcuthbert what did you plan to do here?
I'll convert this to a comment, otherwise the tests fail.
geier
force-pushed
the
develop/plugins
branch
3 times, most recently
from
98cbdcc to
5270180
Compare
so they can be used from plugins without causing circular imports.
doesn't seem to work with python 3.8 otherwise
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First support for plugins
Currently supported:
fixes #1258