Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow int and string (composite) primary keys #181

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Allow int and string (composite) primary keys #181

merged 4 commits into from
Aug 28, 2019

Conversation

dkaera
Copy link
Collaborator

@dkaera dkaera commented Aug 27, 2019

Closes #164

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #181 into develop will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
+ Coverage    77.42%   77.52%   +0.09%     
===========================================
  Files           48       49       +1     
  Lines         1360     1366       +6     
===========================================
+ Hits          1053     1059       +6     
  Misses         307      307
Impacted Files Coverage Δ
floor/lib/src/adapter/migration_adapter.dart 100% <ø> (ø) ⬆️
floor/lib/src/util/primary_key_helper.dart 100% <100%> (ø)
floor/lib/src/adapter/deletion_adapter.dart 85% <100%> (+0.78%) ⬆️
floor/lib/src/adapter/update_adapter.dart 85% <100%> (ø) ⬆️
floor_generator/lib/writer/dao_writer.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d991e3a...ae1dff6. Read the comment docs.

@vitusortner
Copy link
Collaborator

@dkaera Thank you for your contribution! I've just added test for the new functionality and changed the naming a bit.

@vitusortner vitusortner changed the title Fix group primary keys handling. Allow int and string (composite) primary keys Aug 28, 2019
@vitusortner vitusortner merged commit 973baca into pinchbv:develop Aug 28, 2019
@dkaera
Copy link
Collaborator Author

dkaera commented Aug 29, 2019

@dkaera Thank you for your contribution! I've just added test for the new functionality and changed the naming a bit.

You're welcome. I'm glad to help.

@dkaera dkaera deleted the fix/group_identifier branch September 20, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

primary key is assumed to be int for update and delete
2 participants