Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with clear package import instructions #184

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Update README with clear package import instructions #184

merged 3 commits into from
Sep 2, 2019

Conversation

afzaal-ahmad-zeeshan
Copy link
Contributor

It is important to mention that these imports are required; I used Floor but I chose to develop my own classes and had to waste a huge amount of time finding the solution.

This comment can catch eye of the reader and they will know the purpose of these specific imports.

It is important to mention that these imports are required; I used Floor but I chose to develop my own classes and had to waste a huge amount of time finding the solution.
@codecov
Copy link

codecov bot commented Sep 1, 2019

Codecov Report

Merging #184 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #184   +/-   ##
========================================
  Coverage    77.78%   77.78%           
========================================
  Files           49       49           
  Lines         1382     1382           
========================================
  Hits          1075     1075           
  Misses         307      307

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 169c508...9743679. Read the comment docs.

@vitusortner
Copy link
Collaborator

Thanks for your contribution! I'll also update the copy of the README you've edited in order to have them in sync.

@vitusortner vitusortner changed the title Update README.md Update README with clear package import instructions Sep 2, 2019
@vitusortner vitusortner added the enhancement Non code related change label Sep 2, 2019
@vitusortner vitusortner merged commit cdda4ca into pinchbv:develop Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Non code related change
Development

Successfully merging this pull request may close these issues.

2 participants