-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use floor_annotation git ref during development #298
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #298 +/- ##
========================================
Coverage 81.58% 81.58%
========================================
Files 57 57
Lines 1477 1477
========================================
Hits 1205 1205
Misses 272 272
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I just realized that with these changes, we won't be able to use newly added annotations until they're available on Do you have another idea how to solve the |
Maybe...
The downsides of 3 were already discussed, 1 and 2 are pretty complex and we would have to apply them to all drive-by PRs. Otoh, changes to floor_annotation seem to be fairly rare, so this should only be necessary for a handful of PRs. Personally, I'd like to avoid complexities in the PR process so I'm advocating for 3. But I don't have a strong opinion on this, so this would be up to you ;-) |
I'll close this PR for now and remove the snapshot section from the README. |
This allows using snapshot versions of the library. We can't use local paths for snapshot versions as Pub disallows relative paths. I've decided for this solution as we won't change
floor_annotation
that frequently.Closes #288