Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Linux, macOS, Windows #326

Merged
merged 23 commits into from
May 15, 2020
Merged

Support Linux, macOS, Windows #326

merged 23 commits into from
May 15, 2020

Conversation

vitusortner
Copy link
Collaborator

@vitusortner vitusortner commented May 10, 2020

Adds support for Linux, macOS (which didn't seem to work before 🤔) and Windows by using sqflite's ffi implementation when needed.

Closes #228

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #326 into develop will decrease coverage by 0.19%.
The diff coverage is 54.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #326      +/-   ##
===========================================
- Coverage    81.67%   81.47%   -0.20%     
===========================================
  Files           58       59       +1     
  Lines         1495     1506      +11     
===========================================
+ Hits          1221     1227       +6     
- Misses         274      279       +5     
Flag Coverage Δ
#floor 81.47% <54.54%> (-0.20%) ⬇️
#floor_generator 81.13% <ø> (ø)
Impacted Files Coverage Δ
..._generator/lib/writer/database_builder_writer.dart 100.00% <ø> (ø)
floor_generator/lib/writer/database_writer.dart 80.55% <ø> (ø)
floor/lib/src/sqflite_database_factory.dart 54.54% <54.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd726be...22b640f. Read the comment docs.

@vitusortner vitusortner marked this pull request as ready for review May 15, 2020 22:31
@vitusortner vitusortner merged commit 8a63e45 into develop May 15, 2020
@vitusortner vitusortner deleted the desktop-support branch May 15, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Multiple platform support
1 participant