Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention SQL centricity of Floor in README #335

Merged
merged 2 commits into from
May 23, 2020
Merged

Mention SQL centricity of Floor in README #335

merged 2 commits into from
May 23, 2020

Conversation

vitusortner
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 23, 2020 •
edited
Loading

Codecov Report

Merging #335 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #335   +/-   ##
========================================
  Coverage    81.47%   81.47%           
========================================
  Files           59       59           
  Lines         1506     1506           
========================================
  Hits          1227     1227           
  Misses         279      279
Flag Coverage Δ
#floor 81.47% <ø> (ø)
#floor_generator 81.13% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294a316...44c4cad. Read the comment docs.

@vitusortner vitusortner requested a review from mqus May 23, 2020 10:30
mqus
mqus approved these changes May 23, 2020
View reviewed changes
Copy link
Collaborator

@mqus mqus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitusortner vitusortner merged commit 49fbff2 into develop May 23, 2020
@vitusortner vitusortner deleted the improve-readme branch May 23, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mqus mqus mqus approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitusortner @mqus