-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WITHOUT ROWID tables #365
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #365 +/- ##
===========================================
- Coverage 81.51% 81.44% -0.07%
===========================================
Files 59 59
Lines 1509 1525 +16
===========================================
+ Hits 1230 1242 +12
- Misses 279 283 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -100,7 +105,8 @@ class Entity extends Queryable { | |||
primaryKey.hashCode ^ | |||
foreignKeys.hashCode ^ | |||
indices.hashCode ^ | |||
constructor.hashCode; | |||
constructor.hashCode ^ | |||
withoutRowid.hashCode; | |||
|
|||
@override | |||
String toString() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change the toString
method.
So first of all, thank you for your contribution and sorry for not looking at it sooner. I have mainly two minor issues with your code: The first is the Apart from that, I'm pretty happy with your changes. But @vitusortner should probably take a look. |
@mqus Thank you for the review. I will update the code :) |
Thanks for your contribution and thanks for your patience! |
See #358
Added
withoutRowid
parameter to@Entity
annotation, which appendsWITHOUT ROWID
to the CREATE TABLE statement if set to true.Simple test cases included.