Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generation of DAO method with list argument using type converters #416

Merged
merged 3 commits into from
Oct 18, 2020

Conversation

vitusortner
Copy link
Collaborator

Closes #415

@vitusortner vitusortner changed the title Generate DAO method with list argument using type converters Fix generation of DAO method with list argument using type converters Oct 18, 2020
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #416 into develop will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #416      +/-   ##
===========================================
+ Coverage    82.71%   82.83%   +0.12%     
===========================================
  Files           68       68              
  Lines         1660     1660              
===========================================
+ Hits          1373     1375       +2     
+ Misses         287      285       -2     
Flag Coverage Δ
#floor 82.83% <100.00%> (+0.12%) ⬆️
#floor_generator 82.64% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...loor_generator/lib/writer/query_method_writer.dart 100.00% <100.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea6cba...1ba51bd. Read the comment docs.

@vitusortner vitusortner marked this pull request as ready for review October 18, 2020 13:13
@vitusortner vitusortner merged commit d0bac8a into develop Oct 18, 2020
@vitusortner vitusortner deleted the fix-type-converter-DAO-method-list-argument-#415 branch October 18, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Type Converter][Bug] Generating invalid code for a DAO list arguments
1 participant