(refactor) Improve escaping by using library #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor improvement for handling issues like #352 properly.
I still have to add an integration test which tests against the specific issue.
Theoretically we could implement this escaping method ourselves but we would have to keep up with dart language changes.
Another option would be to use
'''
and"""
or evenr'''
but even those can fail in the face of arbitrary queries, so a proper escaping mechanism should be better, since it comes at very little compiletime and no runtime cost.Closes #352