Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Improve escaping by using library #531

Merged
merged 3 commits into from
May 5, 2021

Conversation

mqus
Copy link
Collaborator

@mqus mqus commented Apr 9, 2021

This is just a minor improvement for handling issues like #352 properly.

I still have to add an integration test which tests against the specific issue.

Theoretically we could implement this escaping method ourselves but we would have to keep up with dart language changes.

Another option would be to use ''' and """ or even r''' but even those can fail in the face of arbitrary queries, so a proper escaping mechanism should be better, since it comes at very little compiletime and no runtime cost.

Closes #352

  • Add an integration test

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #531 (a6488ab) into develop (57b4899) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #531   +/-   ##
========================================
  Coverage    90.06%   90.07%           
========================================
  Files           74       74           
  Lines         1852     1853    +1     
========================================
+ Hits          1668     1669    +1     
  Misses         184      184           
Flag Coverage Δ
floor 90.42% <ø> (ø)
floor_generator 90.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...generator/lib/misc/extension/string_extension.dart 100.00% <100.00%> (ø)
floor_generator/lib/writer/database_writer.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b4899...a6488ab. Read the comment docs.

@mqus mqus force-pushed the better-escaping branch from 74d2f4c to ea29b29 Compare April 27, 2021 23:47
Copy link
Collaborator

@vitusortner vitusortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Can't compare fields against blank
3 participants