Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deletion protection #141

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Add support for deletion protection #141

merged 7 commits into from
Jul 17, 2024

Conversation

rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Jul 16, 2024 •
edited
Loading

Problem

Add support for deletion protection.

Solution

Generated code using the following commands:

git submodule init && git submodule update
./codegen/build-oas.sh 2024-07

Next, as a part of this PR, I have:

  1. Added deletionProtection enum as an argument to createPodsIndex() and createServerlessIndex()
  2. Renamed configureIndex() to configurePodsIndex() and added deletionProtection enum as an argument.
  3. Added configureServerlessIndex() that accepts deletionProtection enum only.

Type of Change

  • New feature (non-breaking change which adds functionality)

Test Plan

Added integration tests

@rohanshah18 rohanshah18 changed the title Codegen for deletion protection Add support for deletion protection Jul 17, 2024
@rohanshah18 rohanshah18 marked this pull request as ready for review July 17, 2024 01:30
jhamon
jhamon approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@jhamon jhamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into my feedback on the configure action, I think this is pretty important to avoid surprising people by accidentally turning it off.

src/main/java/io/pinecone/clients/Pinecone.java Outdated Show resolved Hide resolved
austin-denoble
austin-denoble approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than Jen's feedback. Nice job getting this out the door.

src/main/java/io/pinecone/clients/Pinecone.java Outdated Show resolved Hide resolved
@rohanshah18 rohanshah18 merged commit 2ce9ac5 into release-candidate/2024-07 Jul 17, 2024
7 of 8 checks passed
@rohanshah18 rohanshah18 deleted the rshah/deletionProtection branch July 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssmith-pc ssmith-pc ssmith-pc left review comments

@austin-denoble austin-denoble austin-denoble approved these changes

@jhamon jhamon jhamon approved these changes

@aulorbe aulorbe Awaiting requested review from aulorbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohanshah18 @jhamon @austin-denoble @ssmith-pc