Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(ui): show hotkey menu only not focus debug input #73

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Apr 7, 2024

Why are these changes needed?

Previously, the hotkey menu would be invoked even when the user was focused on debug input content. After the improvement, it no longer gets invoked in such cases.

Related issue number

Checks

  • I've included any doc changes needed for https://github.com/pingcap/LinguFlow/.
  • I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • I've made sure all auto checks have passed.

@shhdgit shhdgit changed the title tweak(ui): show hotkey menu when not focus debug input tweak(ui): show hotkey menu only not focus debug input Apr 7, 2024
@shhdgit
Copy link
Member Author

shhdgit commented Apr 9, 2024

@freedeaths done~

Copy link
Collaborator

@freedeaths freedeaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shhdgit shhdgit merged commit 61adf4b into main Apr 10, 2024
1 check passed
@shhdgit shhdgit deleted the tweak-hotkey branch April 10, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants