-
Notifications
You must be signed in to change notification settings - Fork 101
restore: Fix system tables are filtered bug (#1207) #1225
restore: Fix system tables are filtered bug (#1207) #1225
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤔 |
@kennytm |
/run-all-tests |
if !f.MatchSchema(temporaryDB.O) {
log.Debug("system database filtered out", zap.String("database", sysDB))
return
} It seems the temporaryDB.O will be filtered out, and should be replaced with sysDB? |
/run-all-tests |
/build |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 21d5737
|
This is an automated cherry-pick of #1207
What problem does this PR solve?
Fix issue #1197 and #1201
When user only want to restore the system table, i.e. -f "mysql*.*", because the system database was rename to a temporary name, that name will be filtered causing no system table is restored
What is changed and how it works?
When filter restore databases and tables, revert the temporary name to its original name
Check List
Tests
Code changes
Related changes
Release note