Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: fix panic in nextKey #1261

Merged
merged 1 commit into from
Jun 22, 2021
Merged

lightning: fix panic in nextKey #1261

merged 1 commit into from
Jun 22, 2021

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Jun 21, 2021 •
edited
Loading

What problem does this PR solve?

A workaround for #1213.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

No release note.

@ti-chi-bot ti-chi-bot requested review from 3pointer and lichunzhu June 21, 2021 16:32
@sleepymole sleepymole requested review from glorv and kennytm and removed request for 3pointer and lichunzhu June 21, 2021 16:33
@sleepymole sleepymole changed the title lightning: fix panic in nextKey lightning: fix panic in nextKey Jun 21, 2021
kennytm
kennytm approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 22, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jun 22, 2021
@3pointer
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 890df4b

@ti-chi-bot ti-chi-bot merged commit 88936a3 into pingcap:master Jun 22, 2021
@sleepymole sleepymole deleted the nextKey branch June 22, 2021 09:46
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1266.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1267.

ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Jun 22, 2021
@sleepymole @ti-chi-bot
This is an automated cherry-pick of pingcap#1261
848a5b4 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Jun 22, 2021
@sleepymole @ti-chi-bot
This is an automated cherry-pick of pingcap#1261
c894205 
Signed-off-by: ti-chi-bot <[email protected]>
This was referenced Jun 22, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1268.

ti-chi-bot added a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
lightning: fix panic in nextKey (#1261) (#1266)
f2fcbfa
ti-chi-bot added a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
lightning: fix panic in nextKey (#1261) (#1268)
cf9c343
ti-chi-bot added a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
lightning: fix panic in nextKey (#1261) (#1267)
efbec46
@sleepymole sleepymole mentioned this pull request Jun 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm approved these changes

@3pointer 3pointer 3pointer approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 size/XS status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sleepymole @ti-chi-bot @3pointer @kennytm