Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock tools version in Makefile #330

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Mar 11, 2020

Signed-off-by: Yang Keao [email protected]

What problem does this PR solve?

Lock tools version in Makefile. Upgrade controller-gen from 0.2.5 to 0.2.6 is destructive! (related PR)

Signed-off-by: Yang Keao <[email protected]>
@YangKeao YangKeao force-pushed the fix-makefile branch 2 times, most recently from 1ab978e to ad27201 Compare March 11, 2020 08:45
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao YangKeao merged commit 9d57a7d into chaos-mesh:master Mar 11, 2020
@YangKeao YangKeao deleted the fix-makefile branch August 3, 2020 03:43
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants