Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to check install script #915

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Sep 16, 2020

Signed-off-by: cwen0 [email protected]

What problem does this PR solve?

#896 (review)

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@WangXiangUSTC,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: chaos-mesh(slack).

Copy link
Member

@Gallardot Gallardot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it fix this issue #642 as well

@cwen0 cwen0 linked an issue Sep 16, 2020 that may be closed by this pull request
@cwen0
Copy link
Member Author

cwen0 commented Sep 16, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 9be28bf into chaos-mesh:master Sep 16, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 in PR #916

YangKeao pushed a commit to YangKeao/chaos-mesh that referenced this pull request Sep 17, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix install.sh after helm update
4 participants