-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sig-transaction's reviewers #544
Conversation
Signed-off-by: ekexium <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/cc @tisonkun |
@ekexium thanks for creating this PR. I'd suggest you create a vote entry under the directory https://github.com/pingcap/community/tree/master/votes and elaborate nominees' contribution (of course, previous sig-transaction's reviewers is enough, but better to have more details on their work yet). See also the template and https://github.com/tikv/community/pull/139/files#diff-2501407e9d546f432e26d56687cdf445fd1b9798b541cbeeeaee491b00a44fd3 |
8159921
to
3b985bd
Compare
Signed-off-by: ekexium <[email protected]>
3b985bd
to
8072310
Compare
Signed-off-by: ekexium <[email protected]>
We just move the reviewers from tikv/community to here, and we three were promoted as reviewers in that place. Do we need to create vote entry here? |
@you06 actually I call for the migration in #522 multiple times but there is no suggestion on this memberships. It's ok to have some information catch up later but missing the migration window I'd prefer you guys join the team via normal process, i.e., a vote. As mentioned here tikv/community#142 (comment), we tend to avoid exceptions. And a nomination for reviewers, with approvals, last for 72 hours. It won't take a long time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Co-authored-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand it well. How can I vote? Is an approval to this PR enough?
@MyonKeminta: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@MyonKeminta thanks for showing you approval. According the governance rules accepted earlier #522
You can show your approval by GitHub out-of-the-box approval.
So only @pingcap/tidb-maintainers has binding votes to this decision process. Only binding vote counts. For promote a new reviewer, we require a minimal length on 3 days so with 2 approval from @jackysp & @cfzjywxk , this votes will be closed as accepted tomorrow if there is no further objections. |
Co-authored-by: tison <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 09fc57e
|
@cfzjywxk I think you should sign CLA for this repo 😂 |
@ekexium @you06 @longfangsong I've added you in the tidb-reviewers team. |
Add reviewers from the sig-transaction to the TiDB team: @ekexium, @longfangsong, @you06, which is missing in #522