Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

chore: remove no job in queue log #1897

Merged
merged 3 commits into from
Jul 21, 2021
Merged

chore: remove no job in queue log #1897

merged 3 commits into from
Jul 21, 2021

Conversation

Ehco1996
Copy link
Contributor

@Ehco1996 Ehco1996 commented Jul 21, 2021 •
edited
Loading

What problem does this PR solve?

as title

What is changed and how it works?

  • only print log when enable failpoint
  • do not truncate log file when run test case
  • use go scripts to send feishu notify when test failed

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@Ehco1996 Ehco1996 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Jul 21, 2021
GMHDBJD
GMHDBJD reviewed Jul 21, 2021
View reviewed changes
tests/_utils/test_prepare Outdated
truncate -s 0 $WORK_DIR/master/log/dm-master.log
truncate -s 0 $WORK_DIR/worker1/log/dm-worker.log
truncate -s 0 $WORK_DIR/worker2/log/dm-worker.log
# truncate -s 0 $WORK_DIR/master/log/dm-master.log
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a good way. Some tests rely on logs(check_log_contains). In shardddl tests, we run different cases in a single cluster, if we keep previous logs, check_log_contains is imprecise.

@ti-chi-bot ti-chi-bot added size/L and removed size/S labels Jul 21, 2021
lichunzhu
lichunzhu approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jul 21, 2021
GMHDBJD
GMHDBJD approved these changes Jul 21, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 21, 2021
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Jul 21, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 642af8d

@ti-chi-bot ti-chi-bot merged commit fadd543 into pingcap:master Jul 21, 2021
ti-chi-bot pushed a commit to ti-chi-bot/dm that referenced this pull request Jul 21, 2021
@Ehco1996 @ti-chi-bot
This is an automated cherry-pick of pingcap#1897
799177d 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1898.

@Ehco1996 Ehco1996 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Jul 21, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 21, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1901.

ti-chi-bot added a commit that referenced this pull request Jul 22, 2021
@ti-chi-bot
chore: remove no job in queue log (#1897) (#1901)
356f5b6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 size/L status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ehco1996 @ti-chi-bot @GMHDBJD @lichunzhu