Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tikv-br docs #12188

Merged
merged 8 commits into from
Dec 9, 2022
Merged

Add tikv-br docs #12188

merged 8 commits into from
Dec 9, 2022

Conversation

haojinming
Copy link
Contributor

@haojinming haojinming commented Dec 2, 2022 •
edited by qiancai
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@haojinming
add tikv-br doc
45bdf0e 
Signed-off-by: haojinming <[email protected]>
@haojinming
fix br and cdc link
f6d2bdc 
Signed-off-by: haojinming <[email protected]>
@haojinming
add cn link
ea75c4b 
Signed-off-by: haojinming <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hfxsd
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 2, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn December 2, 2022 03:57
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2022
@haojinming haojinming mentioned this pull request Dec 2, 2022
Merged
15 tasks
@shichun-0415 shichun-0415 added translation/from-docs This PR is translated from a PR in pingcap/docs. area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). v6.5 This PR/issue applies to TiDB v6.5. and removed missing-translation-status This PR does not have translation status info. labels Dec 2, 2022
shichun-0415
shichun-0415 reviewed Dec 2, 2022
View reviewed changes
br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
@shichun-0415 shichun-0415 requested review from pingyu and removed request for TomShawn December 2, 2022 06:05
pingyu
pingyu reviewed Dec 3, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
pingyu
pingyu approved these changes Dec 3, 2022
View reviewed changes
Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM~

br/rawkv-backup-and-restore.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
shichun-0415
shichun-0415 approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2022
@shichun-0415
Copy link
Contributor

/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 5, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d360b53

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 5, 2022
@shichun-0415
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2022
@shichun-0415 shichun-0415 requested a review from hfxsd December 5, 2022 11:19
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Dec 5, 2022
@shichun-0415 shichun-0415 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2022
@shichun-0415 shichun-0415 merged commit 4f2ed84 into pingcap:master Dec 9, 2022
@haojinming haojinming deleted the rawkv-br-docs branch December 9, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingyu pingyu pingyu approved these changes

@IANTHEREAL IANTHEREAL IANTHEREAL approved these changes

@hfxsd hfxsd hfxsd approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees

@shichun-0415 shichun-0415

Labels
area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. v6.5 This PR/issue applies to TiDB v6.5.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haojinming @ti-chi-bot @shichun-0415 @pingyu @IANTHEREAL @hfxsd