Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: refined contributing doc #13246

Merged
merged 32 commits into from
Dec 20, 2023
Merged

*: refined contributing doc #13246

merged 32 commits into from
Dec 20, 2023

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Mar 2, 2023

What is changed, added or deleted? (Required)

Added a checklist and style guide.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@hfxsd hfxsd self-assigned this Mar 2, 2023
@ti-chi-bot ti-chi-bot requested a review from TomShawn March 2, 2023 10:39
@hfxsd hfxsd marked this pull request as draft March 2, 2023 10:39
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2023
@hfxsd hfxsd requested a review from lilin90 March 6, 2023 07:39
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. area/general Relates to TiDB overview, architecture, and other general descriptions. and removed missing-translation-status This PR does not have translation status info. labels Mar 6, 2023
@hfxsd hfxsd marked this pull request as ready for review March 6, 2023 12:39
qiancai
qiancai reviewed Dec 20, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Dec 20, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Dec 20, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Dec 20, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Dec 20, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 20, 2023

/rebase

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 20, 2023
hfxsd
hfxsd commented Dec 20, 2023
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Dec 20, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Dec 20, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-20 06:54:39.880666465 +0000 UTC m=+1030370.917893404: ☑️ agreed by qiancai.
  • 2023-12-20 07:36:33.442387267 +0000 UTC m=+1032884.479614193: ☑️ agreed by lilin90.

@lilin90 lilin90 removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2023
@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 20, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 28d6266 into pingcap:master Dec 20, 2023
7 checks passed
@qiancai qiancai removed their assignment Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang left review comments

@qiancai qiancai qiancai approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/general Relates to TiDB overview, architecture, and other general descriptions. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hfxsd @ti-chi-bot @lilin90 @ran-huang @qiancai