Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-statement: calibrate resource support workload #13709

Merged
merged 22 commits into from
Apr 23, 2023
Merged

sql-statement: calibrate resource support workload #13709

merged 22 commits into from
Apr 23, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Apr 17, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)

What is the related PR or file link(s)?

image

@HuSharp
support workload
1176ad9 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2023
@Oreoxmt Oreoxmt added the v7.1 This PR/issue applies to TiDB v7.1. label Apr 17, 2023
@Oreoxmt Oreoxmt requested a review from hfxsd April 17, 2023 04:13
@Oreoxmt Oreoxmt removed the missing-translation-status This PR does not have translation status info. label Apr 17, 2023
@HuSharp HuSharp requested a review from glorv April 17, 2023 04:27
@HuSharp HuSharp marked this pull request as ready for review April 17, 2023 04:28
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2023
glorv
glorv approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuSharp
support workload
baf940e 
Signed-off-by: husharp <[email protected]>
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. labels Apr 18, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 18, 2023

需要等待 pingcap/tidb#43098 合入

@hfxsd hfxsd added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2023
@HuSharp
update
1a4e04c 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2023
@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 18, 2023

@glorv @CabinfeverB PTAL, thx!

@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2023
@hfxsd hfxsd requested a review from Oreoxmt April 18, 2023 03:34
@HuSharp
update
e28d6ca 
Signed-off-by: husharp <[email protected]>
@hfxsd hfxsd mentioned this pull request Apr 18, 2023
Merged
15 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Apr 18, 2023
@HuSharp HuSharp requested a review from songrijie April 19, 2023 00:14
@HuSharp
add parameter
226f633 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2023
@Oreoxmt Oreoxmt self-requested a review April 19, 2023 06:00
HuSharp added 2 commits April 19, 2023 14:25
@HuSharp
address comment
92274ba 
Signed-off-by: husharp <[email protected]>
@HuSharp
address comment
e8c91cb 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp mentioned this pull request Apr 19, 2023
Merged
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 20, 2023

/remove-status LGT2
/status LGT3

@ti-chi-bot ti-chi-bot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Apr 20, 2023
songrijie
songrijie approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@songrijie songrijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hfxsd
Copy link
Collaborator

hfxsd commented Apr 23, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 78a21d7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2023
@ti-chi-bot ti-chi-bot bot merged commit 11d4e39 into pingcap:master Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@glorv glorv glorv approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@songrijie songrijie songrijie approved these changes

Assignees

@hfxsd hfxsd

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HuSharp @ti-chi-bot @Oreoxmt @hfxsd @glorv @songrijie @CabinfeverB