Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource-control: add dashboard panel #13907

Merged
merged 17 commits into from
May 24, 2023
Merged

resource-control: add dashboard panel #13907

merged 17 commits into from
May 24, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented May 10, 2023 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add a new article about TiDB Dashboard Resource Control panel.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)

What is the related PR or file link(s)?

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2023
@HuSharp
update
3cea306 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the add_dashboard_resource_control branch from 1b9f989 to 3cea306 Compare May 10, 2023 01:54
@hfxsd hfxsd added the translation/doing This PR’s assignee is translating this PR. label May 10, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 10, 2023
@hfxsd hfxsd added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v7.1 This PR/issue applies to TiDB v7.1. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 10, 2023
hfxsd
hfxsd reviewed May 10, 2023
View reviewed changes
dashboard/dashboard-intro.md Outdated Show resolved Hide resolved
dashboard/dashboard-intro.md Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added for-release This PR relates to a TiDB release but does not have a tracked feature. and removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 10, 2023
@HuSharp
address comment
597e500 
Signed-off-by: husharp <[email protected]>
hfxsd
hfxsd reviewed May 11, 2023
View reviewed changes
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-statement-list.md Outdated Show resolved Hide resolved
dashboard/dashboard-cluster-info.md Outdated Show resolved Hide resolved
dashboard/continuous-profiling.md Outdated Show resolved Hide resolved
dashboard/dashboard-diagnostics-access.md Outdated Show resolved Hide resolved
dashboard/dashboard-profiling.md Outdated Show resolved Hide resolved
dashboard/dashboard-slow-query.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed May 12, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dashboard/dashboard-slow-query.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
@HuSharp
address comment
62b3617 
Signed-off-by: husharp <[email protected]>
@HuSharp
Copy link
Contributor Author

HuSharp commented May 12, 2023

@Oreoxmt @hfxsd 其他页面的 access 图需要删掉吗？类似下图
https://docs.pingcap.com/zh/tidb/dev/dashboard-slow-query

image

@hfxsd
Copy link
Collaborator

hfxsd commented May 15, 2023

@Oreoxmt @hfxsd 其他页面的 access 图需要删掉吗？类似下图 https://docs.pingcap.com/zh/tidb/dev/dashboard-slow-query

image

删掉吧

@HuSharp HuSharp mentioned this pull request May 15, 2023
Merged
4 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. sig/diagnosis and removed translation/doing This PR’s assignee is translating this PR. labels May 15, 2023
@Oreoxmt Oreoxmt self-requested a review May 15, 2023 07:25
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented May 15, 2023

@Oreoxmt @hfxsd 其他页面的 access 图需要删掉吗？类似下图 docs.pingcap.com/zh/tidb/dev/dashboard-slow-query

image

@HuSharp 可以从文档描述中删除引用图片的部分，但是因为 6.2-7.0 文档中都在使用这些图片，所以不要删除图片的源文件。

因为文档站目前是共用所有分支的图片，删除任一分支上的图片都会导致前端构建时从文档站图片库中删除该图片，此时如果还有其他分支用到该图片，这些分支的网页就会无法加载该图片。

@HuSharp HuSharp force-pushed the add_dashboard_resource_control branch from dfe16b9 to 9229a76 Compare May 15, 2023 09:47
@HuSharp
Copy link
Contributor Author

HuSharp commented May 15, 2023

因为文档站目前是共用所有分支的图片，删除任一分支上的图片都会导致前端构建时从文档站图片库中删除该图片，此时如果还有其他分支用到该图片，这些分支的网页就会无法加载该图片。

好的，已回滚 @Oreoxmt PTAL, thx!

Oreoxmt
Oreoxmt approved these changes May 15, 2023
View reviewed changes
dashboard/dashboard-resource-control.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 15, 2023
@HuSharp
address comment
f2a6f2d 
Signed-off-by: husharp <[email protected]>
HuSharp added 2 commits May 17, 2023 21:09
@HuSharp
update
a6151b6 
Signed-off-by: husharp <[email protected]>
@HuSharp
update
4b5fae1 
Signed-off-by: husharp <[email protected]>
@Oreoxmt Oreoxmt removed the for-release This PR relates to a TiDB release but does not have a tracked feature. label May 18, 2023
@qiancai qiancai added area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. and removed sig/diagnosis labels May 22, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented May 24, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 24, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4b5fae1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2023
@ti-chi-bot ti-chi-bot bot merged commit 5fd68ed into pingcap:master May 24, 2023
@HuSharp HuSharp deleted the add_dashboard_resource_control branch May 24, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@songrijie songrijie songrijie approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@glorv glorv Awaiting requested review from glorv

@baurine baurine Awaiting requested review from baurine

Assignees

@hfxsd hfxsd

Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HuSharp @hfxsd @Oreoxmt @songrijie @CabinfeverB @qiancai