Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: explain more about restore speed in test report #13941

Merged
merged 9 commits into from
May 22, 2023
Merged

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented May 11, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

explain more about restore speed.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 11, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023

测试场景 1([TiDB Cloud](https://tidbcloud.com) 上部署)

- TiKV 节点(8 core,16 GB 内存)数量:21
- 配置:[import] num-threads: 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concurrency 这个配置是什么

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
Copy link
Contributor

@benmaoer benmaoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@benmaoer benmaoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@benmaoer benmaoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. labels May 18, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 18, 2023
@qiancai qiancai added the area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). label May 18, 2023
br/br-pitr-guide.md Outdated Show resolved Hide resolved
br/br-pitr-guide.md Outdated Show resolved Hide resolved
br/br-pitr-guide.md Outdated Show resolved Hide resolved
br/br-pitr-guide.md Outdated Show resolved Hide resolved
@qiancai
Copy link
Collaborator

qiancai commented May 18, 2023

/verify

br/br-pitr-guide.md Outdated Show resolved Hide resolved
br/br-pitr-guide.md Outdated Show resolved Hide resolved
br/br-pitr-guide.md Outdated Show resolved Hide resolved
@qiancai qiancai added needs-cherry-pick-release-6.6 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed needs-cherry-pick-release-6.6 labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2023
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 22, 2023
@qiancai
Copy link
Collaborator

qiancai commented May 22, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023

@qiancai: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qiancai
Copy link
Collaborator

qiancai commented May 22, 2023

/remove-status LGT1
/status LGT3
/merge

@ti-chi-bot ti-chi-bot bot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cc08af5

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit cad2ccd into master May 22, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14032.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/br Indicates that the Issue or PR belongs to the area of BR (Backup & Restore). needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants