Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: add descriptions for some conf items under [flash] section #15039

Merged
merged 6 commits into from
Oct 7, 2023
Merged

tiflash: add descriptions for some conf items under [flash] section #15039

merged 6 commits into from
Oct 7, 2023

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Sep 14, 2023 •
edited by JaySon-Huang
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CalvinNeo
f
5ddc810 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2023
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. v7.4 This PR/issue applies to TiDB v7.4. labels Sep 14, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 14, 2023
@qiancai qiancai added the area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. label Sep 14, 2023
@qiancai qiancai self-assigned this Sep 14, 2023
JaySon-Huang
JaySon-Huang approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai reviewed Sep 19, 2023
View reviewed changes
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2023
@qiancai qiancai mentioned this pull request Sep 20, 2023
Merged
18 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 20, 2023
joey-yez
joey-yez approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@joey-yez joey-yez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

# compact_log_min_rows = 40960 # 40k
# compact_log_min_bytes = 33554432 # 32MB

These two configurations already exist. Only compact_log_min_gap is new added.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

compact_log_min_rows = 40960 # 40k

compact_log_min_bytes = 33554432 # 32MB

These two configurations already exist. Only compact_log_min_gap is new added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 22, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-20 08:36:11.981116507 +0000 UTC m=+679337.948704544: ☑️ agreed by qiancai.
  • 2023-09-22 04:36:02.121593619 +0000 UTC m=+837728.089181670: ☑️ agreed by hfxsd.

@qiancai
Copy link
Collaborator

qiancai commented Oct 7, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7e2b7dd into pingcap:master Oct 7, 2023
@qiancai qiancai added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

@joey-yez joey-yez joey-yez approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees

@qiancai qiancai

Labels
approved area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.4 This PR/issue applies to TiDB v7.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CalvinNeo @qiancai @JaySon-Huang @hfxsd @joey-yez