Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev, v3.0: TiDB cluster configuration changes #1645

Merged
merged 11 commits into from
Jul 23, 2019

Conversation

xiaojingchen
Copy link
Contributor

What is changed, added or deleted?

some configuration changes:

  • remove tikv.storeLabels
  • rewrite 数据容灾

the related PR: pingcap/tidb-operator#663

What is the related PR or file link(s)?

Which version does your change affect?

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

```shell
$ kubectl label node <nodeName> region=<regionName> zone=<zoneName> rack=<rackName> kubernetes.io/hostname=<hostName>
```
如果当前 Kubernetes 集群的 Node 节点没有表示拓扑位置的 Label,或者 Label 名字中带有 `/`,可以通过下面的命令手动给 Node 增加标签:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the following command belong to the following item: 为 TiKV 节点设置所在的 Node 节点的拓扑信息

@yikeke yikeke requested a review from TomShawn July 23, 2019 03:45
@yikeke yikeke changed the title TiDB cluster configuration changes dev, v3.0: TiDB cluster configuration changes Jul 23, 2019
@yikeke
Copy link
Contributor

yikeke commented Jul 23, 2019

The lint issues in this PR have been fixed in the upstream. You can merge upstream master into your current branch to pass the CI check. @xiaojingchen

And before you merge this PR, please wait for @TomShawn to take a look, thanks~

@xiaojingchen xiaojingchen force-pushed the configuration-changes branch from 79f9c93 to cf7c7ce Compare July 23, 2019 05:19
@xiaojingchen
Copy link
Contributor Author

@TomShawn PTAL


目前 TiDB Operator 只能识别特定的几个 label,所以只能使用下面的标签来设置 Node 的拓扑信息
在 Kubernetes 上集成该功能,需要如下操作
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

集成什么功能?

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn merged commit ad242ee into pingcap:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants