-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EBNF for password options #17843
Conversation
@CbcWestwolf: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
For reviewers: Preview ebnf on https://kennytm.github.io/website-docs/dist/
What is changed, added or deleted? (Required)
The
PASSWORD REQUIRE CURRENT DEFAULT
syntax is accepted to be able to parse the output ofSHOW CREATE USER
from MySQL. Especially as this is added by default by MySQL even if not specified when creating the user.In MySQL
PASSWORD REQUIRE CURRENT
andPASSWORD REQUIRE CURRENT OPTIONAL
are also accepted, but TiDB doesn't and the parser won't accept this.As there is no
password_require_current
system variable in TiDB and no other options are accepted this syntax is meaningless / ignored.See also: https://dev.mysql.com/doc/refman/8.4/en/password-management.html#password-reverification-policy
Note that the docs suggested that
CREATE USER 'foo3'@'%' IDENTIFIED BY 'abc' DEFAULT ROLE 'myrole'
should be accepted by TiDB with the role being ignored, but that doesn't seem to be the case.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
pingcap/tidb#53306
Do your changes match any of the following descriptions?