Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EBNF for password options #17843

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jul 2, 2024

For reviewers: Preview ebnf on https://kennytm.github.io/website-docs/dist/

What is changed, added or deleted? (Required)

The PASSWORD REQUIRE CURRENT DEFAULT syntax is accepted to be able to parse the output of SHOW CREATE USER from MySQL. Especially as this is added by default by MySQL even if not specified when creating the user.

In MySQL PASSWORD REQUIRE CURRENT and PASSWORD REQUIRE CURRENT OPTIONAL are also accepted, but TiDB doesn't and the parser won't accept this.

As there is no password_require_current system variable in TiDB and no other options are accepted this syntax is meaningless / ignored.

See also: https://dev.mysql.com/doc/refman/8.4/en/password-management.html#password-reverification-policy

Note that the docs suggested that CREATE USER 'foo3'@'%' IDENTIFIED BY 'abc' DEFAULT ROLE 'myrole' should be accepted by TiDB with the role being ignored, but that doesn't seem to be the case.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

pingcap/tidb#53306

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added for-release This PR relates to a TiDB release but does not have a tracked feature. needs-cherry-pick-release-8.2 translation/from-docs This PR is translated from a PR in pingcap/docs. v8.2 labels Jul 2, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2024
@qiancai qiancai self-assigned this Jul 2, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2024
@qiancai qiancai requested a review from CbcWestwolf July 2, 2024 11:25
Copy link

ti-chi-bot bot commented Jul 3, 2024

@CbcWestwolf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 3, 2024
Copy link

ti-chi-bot bot commented Jul 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-03 02:13:38.434942016 +0000 UTC m=+1376944.920430842: ☑️ agreed by hfxsd.

@qiancai
Copy link
Collaborator Author

qiancai commented Jul 3, 2024

/approve

@qiancai qiancai added the lgtm label Jul 3, 2024
Copy link

ti-chi-bot bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7284408 into pingcap:master Jul 3, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #17850.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. v8.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants