Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend RC instead of SQL Priority #19227

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Recommend RC instead of SQL Priority #19227

merged 2 commits into from
Dec 9, 2024

Conversation

songrijie
Copy link
Contributor

@songrijie songrijie commented Dec 8, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

  • With resource control enabled, PRIORITY in SQL statements is no longer recommended.
  • Recommend QUERY WATCH to manage SQL blacklist.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2024
@songrijie songrijie requested review from glorv and Oreoxmt December 8, 2024 17:03
@songrijie songrijie mentioned this pull request Dec 8, 2024
Merged
16 tasks
@Oreoxmt Oreoxmt self-assigned this Dec 9, 2024
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Dec 9, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 9, 2024
glorv
glorv reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Oreoxmt
Oreoxmt reviewed Dec 9, 2024
View reviewed changes
faq/sql-faq.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-09 05:11:35.482168557 +0000 UTC m=+242485.570971101: ☑️ agreed by Oreoxmt.

@Oreoxmt Oreoxmt removed needs-cherry-pick-release-8.2 needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Dec 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 9, 2024

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 9, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 9, 2024
@Oreoxmt Oreoxmt added the lgtm label Dec 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 49f76f0 into master Dec 9, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the include_description_low_priority branch December 9, 2024 08:28
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19244.

This was referenced Dec 9, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19245.

This was referenced Dec 9, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19246.

This was referenced Dec 9, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
Recommend RC instead of SQL Priority (#19227) (#19245)
f65bbdc
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
Recommend RC instead of SQL Priority (#19227) (#19244)
09e8f03
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
Recommend RC instead of SQL Priority (#19227) (#19246)
fa3fe33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv left review comments

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@songrijie @Oreoxmt @ti-chi-bot @glorv