Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync_diff_inspector: add the check-data-only configuration item #19228

Merged
merged 3 commits into from
Dec 9, 2024
Merged

sync_diff_inspector: add the check-data-only configuration item #19228

merged 3 commits into from
Dec 9, 2024

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Dec 9, 2024 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Close #19190

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 9, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 9, 2024

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 9, 2024

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt December 9, 2024 06:36
@Oreoxmt Oreoxmt mentioned this pull request Dec 9, 2024
Merged
17 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. area/sync-diff-inspector Indicates that the Issue or PR belongs to the area of sync-diff-inspector. labels Dec 9, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Dec 9, 2024
@Oreoxmt Oreoxmt changed the title Update doc of sync_diff_inspector configuration sync_diff_inspector: add the check-data-only configuration item Dec 9, 2024
@Oreoxmt Oreoxmt added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Dec 9, 2024
Oreoxmt
Oreoxmt approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-09 07:00:35.300603463 +0000 UTC m=+249025.389406004: ☑️ agreed by Oreoxmt.

@joechenrh @Oreoxmt
address comments
d549f68 
Co-authored-by: Aolin <[email protected]>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 9, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 91e48ce into pingcap:master Dec 9, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19231.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19232.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19233.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19234.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19235.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19236.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19237.

This was referenced Dec 9, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
sync_diff_inspector: add the check-data-only configuration item (#19228…
916ac36 
…) (#19232)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
sync_diff_inspector: add the check-data-only configuration item (#19228…
7de1fb8 
…) (#19236)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
sync_diff_inspector: add the check-data-only configuration item (#19228…
8dd0337 
…) (#19234)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
sync_diff_inspector: add the check-data-only configuration item (#19228…
347f498 
…) (#19233)
@Oreoxmt Oreoxmt mentioned this pull request Dec 9, 2024
Closed
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
sync_diff_inspector: add the check-data-only configuration item (#19228…
f13d014 
…) (#19231)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
sync_diff_inspector: add the check-data-only configuration item (#19228…
4a3a295 
…) (#19237)
ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@ti-chi-bot
sync_diff_inspector: add the check-data-only configuration item (#19228…
520042f 
…) (#19235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees
No one assigned
Labels
approved area/sync-diff-inspector Indicates that the Issue or PR belongs to the area of sync-diff-inspector. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The 'check-data-only' parameter should be included in the example of config TOML file
5 participants
@joechenrh @CLAassistant @Oreoxmt @ti-chi-bot @D3Hunter