Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: update address and advertise address #3024

Merged
merged 2 commits into from
May 11, 2020
Merged

cdc: update address and advertise address #3024

merged 2 commits into from
May 11, 2020

Conversation

overvenus
Copy link
Member

What is changed, added or deleted? (Required)

Update CDC configuration, replace status-addr with addr and advertise-addr.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@overvenus overvenus requested a review from amyangfei May 11, 2020 04:03
amyangfei
amyangfei approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT1 Indicates that a PR has LGTM 1. needs-cherry-pick-4.0 labels May 11, 2020
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2020
@TomShawn TomShawn assigned TomShawn and ran-huang and unassigned TomShawn May 11, 2020
TomShawn
TomShawn approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit 87a9252 into master May 11, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request May 11, 2020
@overvenus @sre-bot
cdc: update address and advertise address (pingcap#3024)
3b65619
@sre-bot sre-bot mentioned this pull request May 11, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented May 11, 2020

cherry pick to release-4.0 in PR #3025

TomShawn pushed a commit that referenced this pull request May 11, 2020
@sre-bot @overvenus
cdc: update address and advertise address (#3024) (#3025)
66a0fcb 
Co-authored-by: Neil Shen <[email protected]>
@overvenus overvenus deleted the overvenus-patch-1 branch May 11, 2020 09:49
@overvenus overvenus mentioned this pull request May 12, 2020
Merged
5 tasks
@sre-bot sre-bot mentioned this pull request May 13, 2020
Merged
5 tasks
@lilin90 lilin90 added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed translation/doing This PR’s assignee is translating this PR. labels May 20, 2020
rleungx pushed a commit to rleungx/docs-cn that referenced this pull request May 22, 2020
@overvenus @rleungx
cdc: update address and advertise address (pingcap#3024)
e708ad6
@TomShawn TomShawn removed the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Jul 31, 2020
@TomShawn TomShawn added the translation/no-need No need to translate this PR. label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@overvenus @TomShawn @sre-bot @amyangfei @lilin90 @ran-huang