Add description for tidb_distsql_scan_concurrency #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidb_distsql_scan_concurrency Add change description pingcap/tidb#19886
TomShawn
added
needs-cherry-pick-4.0
size/small
wshwsh12
reviewed
Dec 7, 2020
system-variables.md
Outdated
| @@ -299,7 +299,9 @@ SET GLOBAL tidb_distsql_scan_concurrency = 10; | |||
| - 作用域：SESSION | GLOBAL | |||
| - 默认值：15 | |||
| - 这个变量用来设置 scan 操作的并发度。 | |||
| - `v4.0.6` 及其后面版本，该系统变量变更为 `tidb_executor_concurrency` | |||
There was a problem hiding this comment.
看起来4.0没有引入 tidb_executor_concurrency 这个变量啊
There was a problem hiding this comment.
@wshwsh12 是在这个 PR 吗：pingcap/tidb#19886
是否需要在 docs-cn/system-variables.md at master · pingcap/docs-cn 中补充一下这个变量呢？
There was a problem hiding this comment.
@TomShawn pingcap/tidb#19886 引入的是 tidb_union_concurrency 变量，不是tidb_executor_concurrency
tidb_executor_concurrency 这个变量只在 master 上有，并没有引入到 4.0 当中
TomShawn
added
status/require-change
1 similar comment
TomShawn
reviewed
Dec 10, 2020
|
@glkappe, please update your pull request. |
|
@glkappe, please update your pull request. |
ok Co-authored-by: TomShawn <[email protected]>
|
LGTM |
TomShawn
reviewed
Dec 14, 2020
TomShawn
changed the title
ti-srebot
approved these changes
Dec 14, 2020
ti-srebot
pushed a commit
to ti-srebot/docs-cn
that referenced
this pull request
Dec 14, 2020
Signed-off-by: ti-srebot <[email protected]>
10 tasks
|
cherry pick to release-4.0 in PR #5085 |
ti-srebot
added a commit
that referenced
this pull request
Dec 14, 2020
9 tasks
CharLotteiu
added
translation/done
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tidb_distsql_scan_concurrency Add change description
pingcap/tidb#19886
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?