Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dashboard FAQ #6559

Merged
merged 11 commits into from
Jul 29, 2021
Merged

Update dashboard FAQ #6559

merged 11 commits into from
Jul 29, 2021

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Jun 30, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Added a new FAQ for TiDB Dashboard

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

pingcap/docs#5895

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 30, 2021 02:49
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2021
@TomShawn TomShawn added needs-cherry-pick-release-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 30, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 30, 2021
@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 30, 2021
@TomShawn TomShawn added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jul 15, 2021
TomShawn
TomShawn approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@TomShawn
Copy link
Contributor

/rebase

@qiancai qiancai mentioned this pull request Jul 26, 2021
Closed
11 tasks
@shhdgit
Copy link
Member Author

shhdgit commented Jul 29, 2021

请问这个文档现在能合并吗，v4.0.14/5.0.3 已发布

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8fc589e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 29, 2021
@ti-chi-bot ti-chi-bot merged commit 5c16aa1 into pingcap:master Jul 29, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 29, 2021
@shhdgit @ti-chi-bot
This is an automated cherry-pick of pingcap#6559
724c4b7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6762.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6763.

This was referenced Jul 29, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6764.

ti-chi-bot added a commit that referenced this pull request Jul 29, 2021
@ti-chi-bot
Update dashboard FAQ (#6559) (#6762)
dd595b2
ti-chi-bot added a commit that referenced this pull request Jul 29, 2021
@ti-chi-bot
Update dashboard FAQ (#6559) (#6763)
834b5da
ti-chi-bot added a commit that referenced this pull request Jul 29, 2021
@ti-chi-bot
Update dashboard FAQ (#6559) (#6764)
7b6b009
@HuSharp HuSharp mentioned this pull request Aug 4, 2023
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shhdgit @ti-chi-bot @TomShawn