Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add a waring about multi br importing #6890

Merged
merged 7 commits into from
Aug 25, 2021
Merged

br: add a waring about multi br importing #6890

merged 7 commits into from
Aug 25, 2021

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Aug 18, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Added a warning about running multiple BRs in one cluster, which is error-prone.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn August 18, 2021 09:49
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2021
@YuJuncen
Copy link
Contributor Author

/cc @3pointer

@ti-chi-bot ti-chi-bot requested a review from 3pointer August 18, 2021 09:49
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2021
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Aug 18, 2021 •
edited
Loading 

/home/circleci/pingcap/docs-cn/sql-plan-management.md
   325:9  error    shouldn't use full-width char:'（' in en sentence   ZH417
   325:9  warning  in en sen, left parenthesis should half-width '('   ZH420L
  325:13  error    shouldn't use full-width char:'）' in en sentence   ZH417
  325:13  warning  in en sen, right parenthesis should half-width ')'  ZH420R

Why an unrelated file annoys the CI...

@TomShawn
Copy link
Contributor 

/home/circleci/pingcap/docs-cn/sql-plan-management.md
   325:9  error    shouldn't use full-width char:'（' in en sentence   ZH417
   325:9  warning  in en sen, left parenthesis should half-width '('   ZH420L
  325:13  error    shouldn't use full-width char:'）' in en sentence   ZH417
  325:13  warning  in en sen, right parenthesis should half-width ')'  ZH420R

Why an unrelated file annoys the CI...

There's nothing wrong with this PR. The error reporting does not block PR merge.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2021
TomShawn
TomShawn reviewed Aug 19, 2021
View reviewed changes
br/backup-and-restore-faq.md Outdated
@@ -170,3 +170,11 @@ BR 不会备份统计信息（v4.0.9 除外）。所以在恢复存档后需要
BR v4.0.9 备份统计信息使 BR 消耗过多内存，为保证备份过程正常，从 v4.0.10 开始默认关闭备份统计信息的功能。

如果不对表执行 `ANALYZE`，TiDB 会因统计信息不准确而选不中最优化的执行计划。如果查询性能不是重点关注项，可以忽略 `ANALYZE`。

# 是否可以同时启动多个 BR 对单个集群进行恢复？
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 BR 是否有单位呢？集群，实例，节点，还是其他单位呢？

Suggested change
# 是否可以同时启动多个 BR 对单个集群进行恢复？
## 是否可以同时启动多个 BR 对单个集群进行恢复？

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuJuncen cc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

换成了“BR 命令”，用来指代 BR CLI。

@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. labels Aug 19, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Aug 19, 2021
TomShawn
TomShawn approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a3a8883

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2021
@ti-chi-bot ti-chi-bot merged commit e6a57be into pingcap:master Aug 25, 2021
@en-jin19 en-jin19 mentioned this pull request Aug 25, 2021
Merged
12 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@en-jin19 en-jin19

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YuJuncen @ti-chi-bot @TomShawn @3pointer @en-jin19