Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the alert rule of TiKV_thread_apply_worker_cpu_seconds #7747

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Nov 30, 2021

What is changed, added or deleted? (Required)

Changed the alert rule of TiKV_thread_apply_worker_cpu_seconds to the following:

`max(rate(tikv_thread_cpu_seconds_total{name=~"apply_.*"}[1m])) by (instance) > 0.9`

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn November 30, 2021 08:39
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2021
@hfxsd hfxsd requested a review from BusyJay November 30, 2021 08:41
@hfxsd hfxsd self-assigned this Nov 30, 2021
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-5.3 type/bugfix This PR fixes a bug. and removed missing-translation-status This PR does not have translation status info. labels Nov 30, 2021
@hfxsd hfxsd changed the title Update alert-rules.md Changed the alert rule of TiKV_thread_apply_worker_cpu_seconds Nov 30, 2021
@hfxsd hfxsd requested a review from shichun-0415 November 30, 2021 08:47
@hfxsd hfxsd added the ONCALL Relates to documentation oncall. label Nov 30, 2021
@BusyJay
Copy link
Contributor

BusyJay commented Nov 30, 2021

Should wait for tikv/tikv#11517

@ti-chi-bot
Copy link
Member

@BusyJay: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2021
@hfxsd hfxsd added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Dec 1, 2021

Should wait for tikv/tikv#11517

Once this PR is ready for merge, please drop a comment to let us know. Thanks~

@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 29, 2021

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2021
@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 29, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 29, 2021
@hfxsd
Copy link
Collaborator Author

hfxsd commented Dec 29, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d49f243

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 29, 2021
@ti-chi-bot ti-chi-bot merged commit 6440821 into pingcap:master Dec 29, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8080.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants