Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update enable-ttl description #8043

Merged
merged 6 commits into from
Mar 7, 2022
Merged

update enable-ttl description #8043

merged 6 commits into from
Mar 7, 2022

Conversation

7yyo
Copy link
Contributor

@7yyo 7yyo commented Dec 22, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update enable-ttl description

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • en-jin19
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn December 22, 2021 01:52
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 22, 2021
@TomShawn TomShawn added area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. labels Dec 22, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Dec 22, 2021
@TomShawn TomShawn requested review from zier-one and hfxsd December 22, 2021 02:19
tikv-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn TomShawn requested a review from en-jin19 December 28, 2021 08:36
@TomShawn TomShawn assigned en-jin19 and unassigned hfxsd Dec 28, 2021
@shichun-0415 shichun-0415 added needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 11, 2022
Copy link
Collaborator

@hfxsd hfxsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2022
Copy link
Contributor

@en-jin19 en-jin19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@en-jin19
Copy link
Contributor

en-jin19 commented Mar 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c48dcda

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@ti-chi-bot ti-chi-bot merged commit 4db207e into pingcap:master Mar 7, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8579.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8580.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8581.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8582.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8583.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants