Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiKV config: update warnings about enable-ttl #8856

Merged
merged 6 commits into from
Apr 7, 2022
Merged

TiKV config: update warnings about enable-ttl #8856

merged 6 commits into from
Apr 7, 2022

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Apr 6, 2022 •
edited
Loading

What is changed, added or deleted? (Required)

Updated warnings about enable-ttl in "tikv-configuration-file.md".

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added type/enhancement The issue or PR belongs to an enhancement. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-5.0 area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Apr 6, 2022
@en-jin19 en-jin19 requested review from TomShawn and 7yyo April 6, 2022 03:29
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@en-jin19 en-jin19 self-assigned this Apr 6, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2022
@en-jin19 en-jin19 mentioned this pull request Apr 6, 2022
Merged
15 tasks
en-jin19
en-jin19 commented Apr 6, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
7yyo
7yyo approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@7yyo 7yyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2022
TomShawn
TomShawn reviewed Apr 6, 2022
View reviewed changes
tikv-configuration-file.md Outdated
> TTL 暂时只适用于 RawKV 接口。由于所涉及底层数据格式不同，你只能在新建集群时设置该功能。
> **禁止**在已有集群上修改该项配置，否则会导致启动报错。
> **禁止**在有 TiDB 节点的集群中使用该参数，以免导致数据写坏等严重后果。
> - TTL 暂时只适用于 RawKV 接口。由于所涉及底层数据格式不同，你只能在新建集群时设置该功能。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不太明白“所涉及底层数据格式不同”是什么意思。不同的两个主体分别是什么呢？

TomShawn
TomShawn reviewed Apr 6, 2022
View reviewed changes
tikv-configuration-file.md Outdated
> **禁止**在有 TiDB 节点的集群中使用该参数，以免导致数据写坏等严重后果。
> - TTL 暂时只适用于 RawKV 接口。由于所涉及底层数据格式不同，你只能在新建集群时设置该功能。
> - **禁止**在已有集群上修改该项配置，否则会导致启动报错。
> - **禁止**在有 TiDB 节点的集群中使用该参数，否则会导致数据损坏、TiDB 集群升级失败等严重后果。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

无 TiDB 节点的集群是什么集群呢？TiKV 集群吗？

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn 是的，没有 tidb 节点的集群。

TomShawn
TomShawn reviewed Apr 6, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Apr 6, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2022
@en-jin19
Copy link
Contributor Author

en-jin19 commented Apr 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a7a25db

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2022
@ti-chi-bot ti-chi-bot merged commit 796bdf5 into pingcap:master Apr 7, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Apr 7, 2022
@en-jin19 @ti-chi-bot
This is an automated cherry-pick of pingcap#8856
daa56c4 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8908.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8909.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8910.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8911.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8912.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8913.

ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@ti-chi-bot
TiKV config: update warnings about enable-ttl (#8856) (#8909)
1061ba9
ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@ti-chi-bot
TiKV config: update warnings about enable-ttl (#8856) (#8913)
7c461cf
ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@ti-chi-bot
TiKV config: update warnings about enable-ttl (#8856) (#8912)
9a0258f
ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@ti-chi-bot
TiKV config: update warnings about enable-ttl (#8856) (#8910)
2d0a8e2
ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@ti-chi-bot
TiKV config: update warnings about enable-ttl (#8856) (#8908)
c71b0bb
ti-chi-bot added a commit that referenced this pull request Apr 7, 2022
@ti-chi-bot
TiKV config: update warnings about enable-ttl (#8856) (#8911)
9102fe0
This was referenced Apr 15, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7yyo 7yyo 7yyo approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@en-jin19 en-jin19

Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@en-jin19 @ti-chi-bot @TomShawn @7yyo