Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
TomShawn authored Aug 20, 2021
1 parent 1bf5648 commit d7cca2f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion config-templates/geo-redundancy-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ server_configs:
pd:
replication.location-labels: ["zone","dc","rack","host"]
replication.max-replicas: 5
label-property: # Since TiDB 5.2, the `label-property` configuration is not supported by default. To set the replica policy, use the Placement Rules.
label-property: # Since TiDB 5.2, the `label-property` configuration is not supported by default. To set the replica policy, use the placement rules.
reject-leader:
- key: "dc"
value: "sha"
Expand Down
2 changes: 1 addition & 1 deletion geo-distributed-deployment-topology.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ This section describes the key parameter configuration of the TiDB geo-distribut

> **Note:**
>
> Since TiDB 5.2, the `label-property` configuration is not supported by default. To set the replica policy, use the [Placement Rules](/configure-placement-rules.md).
> Since TiDB 5.2, the `label-property` configuration is not supported by default. To set the replica policy, use the [placement rules](/configure-placement-rules.md).

For the further information about labels and the number of Raft Group replicas, see [Schedule Replicas by Topology Labels](/schedule-replicas-by-topology-labels.md).

Expand Down
2 changes: 1 addition & 1 deletion multi-data-centers-in-one-city-deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ member leader_priority pdName3 3

> **Note:**
>
> Since TiDB 5.2, the `label-property` configuration is not supported by default. To set the replica policy, use the [Placement Rules](/configure-placement-rules.md).
> Since TiDB 5.2, the `label-property` configuration is not supported by default. To set the replica policy, use the [placement rules](/configure-placement-rules.md).
**Disadvantages:**

Expand Down
2 changes: 1 addition & 1 deletion three-data-centers-in-two-cities-deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ In the deployment of three DCs in two cities, to optimize performance, you need

> **Note:**
>
> Since TiDB 5.2, the `label-property` configuration is not supported by default. To set the replica policy, use the [Placement Rules](/configure-placement-rules.md).
> Since TiDB 5.2, the `label-property` configuration is not supported by default. To set the replica policy, use the [placement rules](/configure-placement-rules.md).

- Configure the priority of PD. To avoid the situation where the PD leader is in another city (IDC3), you can increase the priority of local PD (in Seattle) and decrease the priority of PD in another city (San Francisco). The larger the number, the higher the priority.

Expand Down

0 comments on commit d7cca2f

Please sign in to comment.