Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the variables of batch-dml #10872

Merged
merged 4 commits into from
Oct 19, 2022
Merged

add the variables of batch-dml #10872

merged 4 commits into from
Oct 19, 2022

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Oct 18, 2022 •
edited by shichun-0415
Loading

Signed-off-by: ekexium [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

close #3155

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2022
@ekexium ekexium force-pushed the batch-dml-variables branch from 36fb64f to d6e9ac6 Compare October 18, 2022 03:26
@ekexium ekexium requested a review from TomShawn October 18, 2022 03:28
ekexium
ekexium commented Oct 18, 2022
View reviewed changes
system-variables.md Outdated
- This variable is used to control whether to enable the batch insert feature, which is part of the deprecated batch-dml feature. When truned on, insert statements may be split into multiple transactions and be committed non-atomically. You must also turn on `tidb_enable_batch_dml` and set a positive `tidb_dml_batch_size` to make it work.

> **Warning:**
> batch-dml is deprecated because it's easy to misuse it and cause data corruption. Consider using [non-transactional DML](/non-transactional-dml.md) instead.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

batch-insert cannot be replaced by non-transactional dml for now, but will be.

@TomShawn TomShawn requested review from cfzjywxk and removed request for shichun-0415 October 18, 2022 04:54
@TomShawn TomShawn self-assigned this Oct 18, 2022
@TomShawn TomShawn added add-missing-docs Add missing system variables to documentation area/transaction Indicates that the Issue or PR belongs to the area of transaction. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. and removed missing-translation-status This PR does not have translation status info. labels Oct 18, 2022
@ekexium ekexium force-pushed the batch-dml-variables branch from 29e8114 to f548f3a Compare October 18, 2022 07:36
@TomShawn TomShawn added the translation/doing This PR's assignee is translating this PR. label Oct 19, 2022
TomShawn
TomShawn reviewed Oct 19, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022
@TomShawn TomShawn removed the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Oct 19, 2022
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 19, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 19, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0d0475d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022
@ti-chi-bot ti-chi-bot merged commit 95c07bc into pingcap:master Oct 19, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10885.

This was referenced Oct 19, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10886.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10887.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 19, 2022
@ekexium @ti-chi-bot
This is an automated cherry-pick of pingcap#10872
55b3920 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 19, 2022
Merged
14 tasks
ti-chi-bot added a commit that referenced this pull request Oct 19, 2022
@ti-chi-bot
add the variables of batch-dml (#10872) (#10885)
24e96c3
ti-chi-bot added a commit that referenced this pull request Oct 19, 2022
@ti-chi-bot
add the variables of batch-dml (#10872) (#10886)
6bb822f
@TomShawn TomShawn mentioned this pull request Oct 19, 2022
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 19, 2022
ti-chi-bot added a commit that referenced this pull request Oct 19, 2022
@ti-chi-bot
add the variables of batch-dml (#10872) (#10887)
1e87dcd
This was referenced Oct 20, 2022
Merged
Merged
Merged
@shichun-0415 shichun-0415 mentioned this pull request Feb 2, 2023
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
add-missing-docs Add missing system variables to documentation area/transaction Indicates that the Issue or PR belongs to the area of transaction. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document missing system variables
4 participants
@ekexium @ti-chi-bot @TomShawn @cfzjywxk