-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LINEAR HASH/KEY mysql compatibility #11085
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@moyun PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to describe PARTITION BY LINEAR HASH
in a new paragraph and remove from current "unsupported" list.
We can say that it is a compatible one, but just at grammar level and we create a hash partition instead. User's original DDL/DML on a MySQL Linear Hash table can keep in use without modification.
OK, so a new paragraph in the partitioned-table.md describing how LINEAR HASH is handled (i.e. like non-linear HASH) and only mention LINEAR KEY in the mysql-compatibility.md ? |
Co-authored-by: Grace Cai <[email protected]>
Co-authored-by: Grace Cai <[email protected]>
@moyun Would you please help review the latest updates of this PR? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Aolin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: Aolin <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a78b4fb
|
In response to a cherrypick label: new pull request created: #11340. |
What is changed, added or deleted? (Required)
See pingcap/tidb#38450 where CREATE TABLE ... PARTITION BY LINEAR HASH will now create a non-linear HASH partitioned table instead of a non-partitioned normal table.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?