Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default values of multiple tiflash configs #7238

Merged
merged 13 commits into from
Jan 24, 2022
Merged

Change the default values of multiple tiflash configs #7238

merged 13 commits into from
Jan 24, 2022

Conversation

hehechen
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

  1. Add description of tiflash-proxy apply-pool-size and store-pool-size configuration. These two configurations have existed since TiDB 4.0 version, this PR is just to supplement the description of the configuration.
  2. TiFlash has changed default values of some configurations, so the doc need to be updated.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Dec 15, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn December 15, 2021 07:13
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2021
@TomShawn TomShawn requested a review from solotzg December 15, 2021 07:13
@TomShawn TomShawn added area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.4 This PR/issue applies to TiDB v5.4. and removed missing-translation-status This PR does not have translation status info. labels Dec 15, 2021
@TomShawn TomShawn changed the title Update tiflash-configuration.md Change the default values of multiple tiflash configs Dec 16, 2021
@shichun-0415 shichun-0415 self-requested a review December 28, 2021 06:02
shichun-0415
shichun-0415 reviewed Dec 28, 2021
View reviewed changes
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 30, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2021
shichun-0415
shichun-0415 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2022
@shichun-0415 shichun-0415 requested a review from qiancai January 5, 2022 08:57
@shichun-0415
Copy link
Contributor

@hehechen Could you please synchronize the change in the default value of status-addr and addr to the English version? Thanks.

qiancai
qiancai reviewed Jan 20, 2022
View reviewed changes
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Show resolved Hide resolved
@shichun-0415
Copy link
Contributor

/verify

qiancai
qiancai approved these changes Jan 24, 2022
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 24, 2022
@qiancai
Copy link
Collaborator

qiancai commented Jan 24, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cc1f8c1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 24, 2022
@ti-chi-bot ti-chi-bot merged commit b0f76a7 into pingcap:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@qiancai qiancai qiancai approved these changes

@solotzg solotzg solotzg approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hehechen @ti-chi-bot @shichun-0415 @qiancai @solotzg @TomShawn