address comments

pingcap · Jul 12, 2021 · 62c52a8 · 62c52a8
1 parent 88e84cc
commit 62c52a8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/v4/export/dump.go b/v4/export/dump.go
@@ -243,7 +243,6 @@ func (d *Dumper) Dump() (dumpErr error) {
 		summary.CollectFailureUnit("dump table data", err)
 		return errors.Trace(err)
 	}
-	finishedRowsCounter.DeleteLabelValues("")
 	summary.CollectSuccessUnit("dump cost", countTotalTask(writers), time.Since(tableDataStartTime))
 
 	summary.SetSuccessStatus(true)

diff --git a/v4/export/sql_test.go b/v4/export/sql_test.go
@@ -1214,8 +1214,7 @@ func readRegionCsvDriverValues(c *C) [][]driver.Value {
 		}
 		regionID, err := strconv.Atoi(results[0])
 		c.Assert(err, IsNil)
-		startKey := strings.Trim(results[1], `"`)
-		endKey := strings.Trim(results[2], `"`)
+		startKey, endKey := results[1], results[2]
 		values = append(values, []driver.Value{regionID, startKey, endKey})
 	}
 	return values