Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

export: initial work to support MemSQL/SingleStore (#311) #327

Merged
merged 4 commits into from
Aug 23, 2021
Merged

export: initial work to support MemSQL/SingleStore (#311) #327

merged 4 commits into from
Aug 23, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #311

What problem does this PR solve?

Issue: #309

  • WITH CONSISTENT SNAPSHOT is not supported by MemSQL (same for Vitess).
  • SHOW CREATE DATABASE is not supported by MemSQL.

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

  • Support for backing up MySQL compatible databases that don't support START TRANSACTION ... WITH CONSISTENT SNAPSHOT
  • Support for backing up MySQL compatible databases that don't support SHOW CREATE TABLE

@dveeden @ti-chi-bot
Initial work to support MemSQL/SingleStore
cf69df4 
Issue: pingcap#309

- `WITH CONSISTENT SNAPSHOT` is not supported by MemSQL (same for
  Vitess).
- `SHOW CREATE DATABASE` is not supported by MemSQL.
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2021
Merged
@ti-chi-bot ti-chi-bot requested review from kennytm and lichunzhu August 3, 2021 14:33
lichunzhu
lichunzhu approved these changes Aug 23, 2021
View reviewed changes
v4/export/sql.go Outdated Show resolved Hide resolved
v4/export/sql.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label Aug 23, 2021
lichunzhu
lichunzhu reviewed Aug 23, 2021
View reviewed changes
v4/export/sql.go Outdated Show resolved Hide resolved
lichunzhu
lichunzhu approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 1cdd198

@ti-chi-bot ti-chi-bot merged commit ea5e15d into pingcap:release-5.0 Aug 23, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.0.4 milestone Sep 10, 2021
@Little-Wallace Little-Wallace mentioned this pull request Sep 14, 2021
Merged
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
cherry-pick-approved size/S status/can-merge status/LGT1 One reviewer approved (LGTM1)
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @lichunzhu @zhouqiang-cl @nongfushanquan @dveeden