Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: change default charset from utf8 to utf8mb4 #13

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Nov 5, 2018

Required for pingcap/tidb#7965

@winkyao
Copy link
Contributor Author

winkyao commented Nov 5, 2018

@tiancaiamao PTAL

@kennytm
Copy link
Contributor

kennytm commented Nov 5, 2018

Please regenerate parser.go since you've modified parser.y.

@gregwebs
Copy link

gregwebs commented Nov 5, 2018

LGTM

@winkyao
Copy link
Contributor Author

winkyao commented Nov 6, 2018

@kennytm PTAL

@kennytm kennytm added status/LGT2 LGT2 and removed DNM status/LGT1 LGT1 labels Nov 6, 2018
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit 2cc1858 into pingcap:master Nov 6, 2018
@winkyao winkyao deleted the charset_mb4 branch November 6, 2018 07:34
zimulala added a commit to zimulala/parser that referenced this pull request Nov 8, 2018
zimulala added a commit to zimulala/parser that referenced this pull request Nov 8, 2018
Revert "*: change default charset from utf8 to utf8mb4 (pingcap#13)"
tiancaiamao added a commit to tiancaiamao/parser that referenced this pull request Nov 22, 2018
winkyao added a commit to winkyao/parser that referenced this pull request Dec 6, 2018
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants