-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser : support drop sequence syntax. #680
Conversation
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
=========================================
+ Coverage 79.82% 80.13% +0.3%
=========================================
Files 37 33 -4
Lines 13596 13030 -566
=========================================
- Hits 10853 10441 -412
+ Misses 2100 1967 -133
+ Partials 643 622 -21
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
cedfab3
to
bf3ec8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
TiDB are compatible with MySQL's protocol, we should be also compatible with SEQUENCE implementation of MariaDB cause MySQL is absent from it.
Linked with sequence project, this PR try to support drop sequence syntax.
What is changed and how it works?
SHOW CREATE SEQUENCE sequence_name;
ALTER SEQUENCE [IF EXISTS] sequence_name [ INCREMENT [ BY | = ] increment ] [ MINVALUE [=] minvalue | NO MINVALUE | NOMINVALUE ] [ MAXVALUE [=] maxvalue | NO MAXVALUE | NOMAXVALUE ] [ START [ WITH | = ] start ] [ CACHE [=] cache ] [ [ NO ] CYCLE ] [ RESTART [[WITH | =] restart];
DROP [TEMPORARY] SEQUENCE [IF EXISTS] sequence_name [, sequence_name] ...
Sequence Function (need discussion)
Check List
Tests