-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreserved 8 keywords #851
Conversation
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
=======================================
Coverage 78.28% 78.28%
=======================================
Files 40 40
Lines 14667 14667
=======================================
Hits 11482 11482
Misses 2502 2502
Partials 683 683 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
hmm what's the difference between UnreservedKeyword, NotKeyword and TiDBKeyword? |
I'm not sure there is any difference between NonKeyword and UnreservedKeyword. https://dev.mysql.com/doc/refman/5.7/en/keywords.html If you are not sure as well, I think we can merge this change. Anyway, nobody knows or cares about it. @kennytm |
LGTM |
/run-cherry-picker |
cherry pick to release-3.0 failed |
1 similar comment
cherry pick to release-3.0 failed |
cherry pick to release-3.1 failed |
1 similar comment
cherry pick to release-3.1 failed |
cherry pick to release-4.0 failed |
cherry pick to release-4.0 failed |
okay. |
* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords
* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords
* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords Co-authored-by: kennytm <[email protected]>
hi @kennytm could please help cherry-pick this to 3.0 and 3.1, some customers meet this problem too in 3.0, thanks~ |
* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords
* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords
* parser.y: unreserve 8 keywords * consistent_test: added an optional test to check against MySQL keywords
What problem does this PR solve?
Fix #846.
What is changed and how it works?
Unreserved the following 8 keywords:
And added a manually executed test case to ensure the list of reserved keywords mostly match that of MySQL. The only discrepancy currently are:
SET ROLE
support #228, caused significant reduce/reduce conflict when unreserved, cc @imtbkcat)Check List
Tests
Code changes
Side effects
Related changes
Release note
CHAIN
,ERROR
,GENERAL
,NVARCHAR
,PACK_KEYS
,PARSER
,SHARD_ROW_ID_BITS
andPRE_SPLIT_REGIONS
are no longer treated as reserved words.