Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: correct the usage of json.Unmarshal in DecodeArgs (#890) #895

Merged
merged 2 commits into from
Jun 16, 2020

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Jun 11, 2020

Cherry-pick #890

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #895 into release-4.0 will decrease coverage by 0.01%.
The diff coverage is 63.63%.

@@               Coverage Diff               @@
##           release-4.0     #895      +/-   ##
===============================================
- Coverage        78.34%   78.32%   -0.02%     
===============================================
  Files               40       40              
  Lines            14770    14778       +8     
===============================================
+ Hits             11571    11575       +4     
- Misses            2517     2519       +2     
- Partials           682      684       +2     

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Jun 16, 2020

/merge

@bobotu bobotu merged commit a87fd8a into pingcap:release-4.0 Jun 16, 2020
@bobotu bobotu deleted the 4.0-fix-1.15 branch June 16, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants